Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #23990 - Allow for Nimbus experimentation for Contile top sites #23996

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Feb 25, 2022

Fixes #23990. https://experimenter.services.mozilla.com/nimbus/android-nightly-sponsored-shortcuts-validation/

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested review from a team as code owners February 25, 2022 21:02
@gabrielluong gabrielluong requested a review from jhugman February 25, 2022 21:02
@gabrielluong gabrielluong reopened this Feb 25, 2022
@gabrielluong gabrielluong reopened this Feb 27, 2022
@gabrielluong gabrielluong force-pushed the 23990 branch 3 times, most recently from 5197f43 to 795e8bd Compare March 2, 2022 14:52
@gabrielluong gabrielluong reopened this Mar 2, 2022
@gabrielluong gabrielluong force-pushed the 23990 branch 2 times, most recently from fc45a32 to cf17899 Compare March 2, 2022 22:25
@gabrielluong gabrielluong added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Mar 4, 2022
@mergify mergify bot merged commit 65b1716 into mozilla-mobile:main Mar 4, 2022
@gabrielluong gabrielluong deleted the 23990 branch March 4, 2022 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect the top sites contile work to Nimbus
2 participants